GHSA-34fj-mwm6-fjfg CVE-2026-72794 GO-2026-6420
SiYuan: The session-cookie signing key (Conf.CookieKey) is returned to anonymous readers by /api/system/getConf
- Severity
- 9.2 / 10
- Critical · CVSS 4.0
- Exploit chance (EPSS)
- 0.33%
- Chance of exploitation in the next 30 days. Higher than 25.58% of scored vulnerabilities.
- Known exploited
- No
- Not in CISA's catalog
- Weakness
- CWE-522 Insufficiently Protected Credentials
- Fix
0.0.0-20260725123945-77421530be4a- Upgrade github.com/siyuan-note/siyuan/kernel to this version or later
Description
CVE: This vulnerability corresponds to CVE-2026-72794.
Summary
/api/system/getConf returns Conf.CookieKey, the key used to sign the server's session cookies in its response body. The endpoint is registered with CheckAuth only, so the field reaches the publish RoleReader token and the anonymous account when Publish.Auth.Enable is false.
The configuration-export endpoint in the same file strips this exact field before returning config, so the project already treats it as secret. The reader-facing masking path does not.
Details
| Item | Detail |
|---|---|
| Route | kernel/api/router.go:70 POST /api/system/getConf → model.CheckAuth → getConf |
| Middleware | CheckAuth only — no CheckReadonly, no CheckAdminRole |
| Leaked field | AppConf.CookieKey, serialized as cookieKey |
| Purpose of the field | Signing key for the siyuan session cookie |
The field survives every stage of the masking chain. getConf masks through GetMaskedConf() → HideConfSecret() (non-administrators) → FilterConfByPublishIgnore() (readers) → the browser-side System-path strip. CookieKey is removed by none of them:
GetMaskedConfmasksUserData,MCPOAuthandAccessAuthCodeonly.HideConfSecretnullsAI,Api,Flashcard,ServerAddrs,Publish,Repo,Sync,Secrets,Variablesand the System paths. It contains no reference toCookieKey.FilterConfByPublishIgnoretouchesUILayoutonly.- The browser-side strip removes System paths only.
The key is live, not vestigial. It is passed straight into the session store at startup:
cli/cmd/serve.go:67 go server.Serve(false, model.Conf.CookieKey)
kernel/server/serve.go:152 sessionStore = cookie.NewStore([]byte(cookieKey))
kernel/server/serve.go:159 ginServer.Use(sessions.Sessions("siyuan", sessionStore))
gin-contrib/sessions/cookie.NewStore constructed with a single key uses that key as the gorilla/securecookie HMAC key. The siyuan session cookie is therefore signed with the value the endpoint hands out. An attacker holding it can mint and modify session cookies that the server accepts as authentic.
Guarded sibling, in the same file. exportConf (kernel/api/system.go:299) clones the configuration before returning it and explicitly clears both secrets:
kernel/api/system.go:360 clonedConf.CookieKey = ""
clonedConf.NotebookCrypto = nil
The project has already classified CookieKey as a value that must not leave the server. The getConf masking path omits the same field.
Ceiling is environment-dependent, floor is not. Escalating a forged session to administrator additionally requires the forged SessionData to carry the matching AccessAuthCode, which GetMaskedConf does mask or the instance to have no access-auth code configured, which is a common deployment. The unconditional impact, present on every instance, is the disclosure of a persistent cryptographic secret to an unauthenticated party together with the cookie-forgery capability that follows from it. Rotating the key invalidates all existing sessions, so this is not a secret that can be quietly refreshed.
Proof of Concept
Precondition: publish mode enabled (default port 6808); anonymous when Publish.Auth.Enable is false, otherwise any publish reader account.
POST http://127.0.0.1:6808/api/system/getConf
{}
→ 200
The response body's conf object contains a cookieKey field holding the
server's session-signing key in cleartext.
Differential check against the endpoint that does strip it:
POST http://127.0.0.1:6808/api/system/exportConf
→ cookieKey is empty, notebookCrypto is null
The same value is withheld by one endpoint and returned by the other.
Impact
An anonymous reader in publish mode or any publish RoleReader obtains the server's session-cookie signing key. This is a persistent cryptographic secret whose disclosure cannot be remediated without invalidating every active session. Possession of the key permits forging and tampering with siyuan session cookies that the server will validate as authentic. On instances with no access-auth code configured, or where a forged session's contents otherwise satisfy the server's checks, this extends to authenticating as a privileged user.
Suggested fix
Clear CookieKey in HideConfSecret for all non-administrator responses. The more durable fix is to route non-administrator getConf through the exportConf cloner, which already handles CookieKey, NotebookCrypto, Account, Stat, System.ID, Export.PandocBin and the AI keys replacing the current blocklist, which fails open on every field nobody thought to add, with the allowlist-style cloner the project already maintains.
Affected versions
Go
| Package | Vulnerable | Fixed in |
|---|---|---|
| github.com/siyuan-note/siyuan/kernel | < 0.0.0-20260725123945-77421530be4a |
0.0.0-20260725123945-77421530be4a |
How to fix
Move to the fixed version or later with your package manager, update the lockfile, and run your tests. If the package only arrives through another dependency, upgrade that dependency first. If none of its releases pulls a fixed version yet, force the version with your package manager's override.
github.com/siyuan-note/siyuan/kernel Go → 0.0.0-20260725123945-77421530be4a
- go
go get github.com/siyuan-note/siyuan/kernel@v0.0.0-20260725123945-77421530be4a && go mod tidy
Severity breakdown
CVSS 4.0 9.2
CVSS:4.0/AV:N/AC:L/AT:N/PR:N/UI:N/VC:H/VI:N/VA:N/SC:H/SI:N/SA:N/E:X/CR:X/IR:X/AR:X/MAV:X/MAC:X/MAT:X/MPR:X/MUI:X/MVC:X/MVI:X/MVA:X/MSC:X/MSI:X/MSA:X/S:X/AU:X/R:X/V:X/RE:X/U:X
- Attack vector
- Network
- Attack complexity
- Low
- Attack requirements
- None
- Privileges required
- None
- User interaction
- None
- Confidentiality (vulnerable system)
- High
- Integrity (vulnerable system)
- None
- Availability (vulnerable system)
- None
- Confidentiality (subsequent systems)
- High
- Integrity (subsequent systems)
- None
- Availability (subsequent systems)
- None
- Exploit maturity
- Not defined
- Scope
- X
CVSS 3.1 8.6
CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:C/C:H/I:N/A:N
- Attack vector
- Network
- Attack complexity
- Low
- Privileges required
- None
- User interaction
- None
- Scope
- Changed
- Confidentiality
- High
- Integrity
- None
- Availability
- None
Weakness
CWE-522: Insufficiently Protected Credentials
The product transmits or stores authentication credentials, but it uses an insecure method that is susceptible to unauthorized interception and/or retrieval.
How to prevent it
- Architecture and Design: Use an appropriate security mechanism to protect the credentials.
- Architecture and Design: Make appropriate use of cryptography to protect the credentials.
- Implementation: Use industry standards to protect the credentials (e.g. LDAP, keystore, etc.).
References
Advisories
Packages
Other links
Timeline
- Published
- Last updated by the source
- Latest EPSS score
Related advisories
| Advisory | Severity | Why it's related |
|---|---|---|
| GHSA-xp3q-r38w-vgqm SiYuan: The publish filter for local storage returns the administrator's entire storage map with only three keys sanitized | Medium | Also affects github.com/siyuan-note/siyuan/kernel |
| GHSA-9cqf-hhrq-7v45 SiYuan: getAttributeViewSearchTarget returns database row content to anonymous readers with no publish-access check, reopening the class closed one day earlier at the adjacent route | High | Also affects github.com/siyuan-note/siyuan/kernel |
| GHSA-57v5-wqx3-cgj4 SiYuan: Database view structure (all view names, layout types and per-field visibility) is returned to anonymous readers by /api/av/getAttributeViewFieldViews | Medium | Also affects github.com/siyuan-note/siyuan/kernel |
| GHSA-4wwp-f6gw-6qm5 SiYuan: TLS Private Keys Readable via getFile (Incomplete Blocklist) | High | Also affects github.com/siyuan-note/siyuan/kernel |
| GHSA-3cm4-ccvw-6xr6 SiYuan: /history/*path and /repo/diff/*path potentially exposing historical snapshots of data/.siyuan/publishAccess.json and data/templates/* | Medium | Also affects github.com/siyuan-note/siyuan/kernel |
| GHSA-x8gv-g2g3-65fj SiYuan Agent Tools SSRF via DNS-Rebinding TOCTOU (Bypass of CheckHostSSRF) | High | Also affects github.com/siyuan-note/siyuan/kernel |
| GHSA-p23f-cm6q-2qp8 SiYuan MCP asset.upload Reads Arbitrary Absolute File Paths (Workspace Boundary Bypass) | Medium | Also affects github.com/siyuan-note/siyuan/kernel |
| GHSA-rpx2-p6hp-x5gj SiYuan: Missing consistency check between packageName and repoURL/repoHash in bazaar package install allows overwriting an existing, trusted plugin | Medium | Also affects github.com/siyuan-note/siyuan/kernel |
MergeHarbor checks every repository's dependencies against this database, ranks what matters by exploitability and reachability, routes it to the owning team and opens the fix pull request.
Check your repos with MergeHarbor